Fetch certs from security repo and remove locally checked in demo certs #713
+21
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo,
vibrantvarun and
prudhvigodithi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=========================================
Coverage 37.67% 37.67%
Complexity 135 135
=========================================
Files 22 22
Lines 1189 1189
Branches 109 109
=========================================
Hits 448 448
Misses 704 704
Partials 37 37 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
approved these changes
Jan 22, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ts (#713) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit a659592) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a quick follow-up to opensearch-project/security#4896 to remove the locally checked in demo certs. Since the original PR was opened, there's been an effort to remove any demo certs checked into plugin repos in favor of getting them from the security repo. Example PR: opensearch-project/index-management#1303
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.