-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Consistency Tests with ML-Common and Set Up Daily GitHub Action Trigger #937
Conversation
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
=========================================
Coverage 78.07% 78.07%
Complexity 996 996
=========================================
Files 99 99
Lines 4625 4625
Branches 431 431
=========================================
Hits 3611 3611
Misses 834 834
Partials 180 180 ☔ View full report in Codecov by Sentry. |
@dbwiddis Hi Dan, when you have a moment, could you help review my PR? Thanks a lot:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor suggestions.
src/main/java/org/opensearch/flowframework/util/ApiSpecFetcher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Junwei Dai <[email protected]>
…on Trigger (#937) * Added the rest api spec comparison test Signed-off-by: Junwei Dai <[email protected]> * Added github Action to run api consistency test daily Signed-off-by: Junwei Dai <[email protected]> * fix formating issue Signed-off-by: Junwei Dai <[email protected]> * add change log Signed-off-by: Junwei Dai <[email protected]> * fix *import Signed-off-by: Junwei Dai <[email protected]> * addrssed all comment Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]> (cherry picked from commit 50e45ac) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ily GitHub Action Trigger (#942) Add API Consistency Tests with ML-Common and Set Up Daily GitHub Action Trigger (#937) * Added the rest api spec comparison test * Added github Action to run api consistency test daily * fix formating issue * add change log * fix *import * addrssed all comment --------- (cherry picked from commit 50e45ac) Signed-off-by: Junwei Dai <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Junwei Dai <[email protected]>
Description
compareRequiredFields
method inApiFetcher
to usecontainsAll
instead ofequal
, ensuring that all required fields for our step inputs are included. For example, whileregisterLocalModel
andregisterRemoteModel
require different input parameters, they both call the same API in ML Common.Related Issues
Resolves #908
Resolves #651
Issue Related #833
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.