Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #880: Remove temporary fix for integration tests #930

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

saimedhi
Copy link
Contributor

Description

Revert PR #880: Remove temporary fix for integration tests

Related Issues

Related to #880

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (5647132) to head (a79e2ef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #930   +/-   ##
=========================================
  Coverage     78.07%   78.07%           
  Complexity      996      996           
=========================================
  Files            99       99           
  Lines          4625     4625           
  Branches        431      431           
=========================================
  Hits           3611     3611           
  Misses          834      834           
  Partials        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi
Copy link
Contributor Author

Integ tests failing. Will try to fix them.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would prefer to keep this code in for 2.18.0 release so we can verify it's not goign to be flaky again.

OK with merging this main branch PR, but let's wait to merge the 2.x backport until after the 2.19.0-SNAPSHOT version bump on 2.x.

@dbwiddis dbwiddis merged commit 79bd859 into opensearch-project:main Oct 23, 2024
23 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
Signed-off-by: saimedhi <[email protected]>
(cherry picked from commit 79bd859)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Nov 7, 2024
…ests (#931)

Revert PR #880: Remove temporary fix for integration tests (#930)


(cherry picked from commit 79bd859)

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants