-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR #880: Remove temporary fix for integration tests #930
Conversation
…n tests Signed-off-by: saimedhi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
=========================================
Coverage 78.07% 78.07%
Complexity 996 996
=========================================
Files 99 99
Lines 4625 4625
Branches 431 431
=========================================
Hits 3611 3611
Misses 834 834
Partials 180 180 ☔ View full report in Codecov by Sentry. |
Integ tests failing. Will try to fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would prefer to keep this code in for 2.18.0 release so we can verify it's not goign to be flaky again.
OK with merging this main
branch PR, but let's wait to merge the 2.x backport until after the 2.19.0-SNAPSHOT version bump on 2.x.
Signed-off-by: saimedhi <[email protected]> (cherry picked from commit 79bd859) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ests (#931) Revert PR #880: Remove temporary fix for integration tests (#930) (cherry picked from commit 79bd859) Signed-off-by: saimedhi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Revert PR #880: Remove temporary fix for integration tests
Related Issues
Related to #880
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.