Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Introduce global-context index and related operations #76

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c4f1fc7 from #65.

* Add global context index and indices handler

Signed-off-by: Jackie Han <[email protected]>

* Update global context index mapping

Signed-off-by: Jackie Han <[email protected]>

* correct checkstyle errors

Signed-off-by: Jackie Han <[email protected]>

* skip index handler integ tests

Signed-off-by: Jackie Han <[email protected]>

* remove indices integration tests for now

Signed-off-by: Jackie Han <[email protected]>

* rebase - add global-context index handler

Signed-off-by: Jackie Han <[email protected]>

* Add unit tests

Signed-off-by: Jackie Han <[email protected]>

* remove duplicate index name file

Signed-off-by: Jackie Han <[email protected]>

* refactor package and file names

Signed-off-by: Jackie Han <[email protected]>

* spotless apply

Signed-off-by: Jackie Han <[email protected]>

* add javax ws dependency

Signed-off-by: Jackie Han <[email protected]>

* remove visible for testing

Signed-off-by: Jackie Han <[email protected]>

* add final keyword to map in Template ToXContect parser

Signed-off-by: Jackie Han <[email protected]>

* spotless apply

Signed-off-by: Jackie Han <[email protected]>

* disable checkStyleTest

Signed-off-by: Jackie Han <[email protected]>

* Add more unit tests

Signed-off-by: Jackie Han <[email protected]>

* use OpenSearch rest status code

Signed-off-by: Jackie Han <[email protected]>

* Addressing comments

Signed-off-by: Jackie Han <[email protected]>

* update resposnes field name to userOutputs

Signed-off-by: Jackie Han <[email protected]>

* spotlessApply

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit c4f1fc7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #76 (a218e7d) into 2.x (882af17) will decrease coverage by 7.59%.
The diff coverage is 61.20%.

@@             Coverage Diff              @@
##                2.x      #76      +/-   ##
============================================
- Coverage     91.68%   84.09%   -7.59%     
- Complexity      167      197      +30     
============================================
  Files            13       18       +5     
  Lines           565      742     +177     
  Branches         78       90      +12     
============================================
+ Hits            518      624     +106     
- Misses           24       88      +64     
- Partials         23       30       +7     
Files Coverage Δ
.../opensearch/flowframework/FlowFrameworkPlugin.java 100.00% <100.00%> (ø)
...arch/flowframework/indices/FlowFrameworkIndex.java 100.00% <100.00%> (ø)
...pensearch/flowframework/workflow/WorkflowData.java 100.00% <ø> (ø)
...ch/flowframework/workflow/WorkflowStepFactory.java 64.70% <100.00%> (ø)
...g/opensearch/flowframework/common/CommonValue.java 66.66% <66.66%> (ø)
.../flowframework/common/ThrowingSupplierWrapper.java 50.00% <50.00%> (ø)
...a/org/opensearch/flowframework/model/Template.java 90.41% <83.78%> (-1.95%) ⬇️
...lowframework/exception/FlowFrameworkException.java 0.00% <0.00%> (ø)
...ch/flowframework/indices/GlobalContextHandler.java 68.42% <68.42%> (ø)
...search/flowframework/workflow/CreateIndexStep.java 58.33% <47.36%> (-26.52%) ⬇️

@dbwiddis
Copy link
Member

dbwiddis commented Oct 9, 2023

WIndows IT tests are failing, does not seem to have the correct IP for the cluster:

org.opensearch.client.ResponseException: method [GET], host [http://0.0.0.0:0/], URI [/_cat/plugins], status line [HTTP/1.1 404 Not Found]

@dbwiddis dbwiddis merged commit 3aa4c9e into 2.x Oct 9, 2023
14 of 16 checks passed
@dbwiddis dbwiddis deleted the backport/backport-65-to-2.x branch October 9, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant