-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishes snapshot to maven and adds DEV guide #68
Publishes snapshot to maven and adds DEV guide #68
Conversation
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
=========================================
Coverage 84.09% 84.09%
Complexity 197 197
=========================================
Files 18 18
Lines 742 742
Branches 90 90
=========================================
Hits 624 624
Misses 88 88
Partials 30 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add something to the developer guide telling people how to use this snapshot to install the extension. Does it publish a .zip?
46ee735
to
9b655e5
Compare
|
9e5f720
to
1b9d4ee
Compare
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
1b9d4ee
to
bc682f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a small comment
Signed-off-by: Owais Kazi <[email protected]>
b2543c0
to
549dd6e
Compare
* Publish snapshot to maven Signed-off-by: Owais Kazi <[email protected]> * Updated build.gradle file to publish artifacts correctly Signed-off-by: Owais Kazi <[email protected]> * Added DEV guide to the repo Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comment Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 71123d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Publishes snapshot to maven and adds DEV guide (#68) * Publish snapshot to maven * Updated build.gradle file to publish artifacts correctly * Added DEV guide to the repo * Addressed PR comment --------- (cherry picked from commit 71123d4) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Publish snapshot to maven and added dev guide to the repo.
Once opensearch-project/opensearch-build#4106 is done, we can open this PR.
Issues Resolved
Fixes #72
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.