Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishes snapshot to maven and adds DEV guide #68

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Oct 1, 2023

Description

Publish snapshot to maven and added dev guide to the repo.

Once opensearch-project/opensearch-build#4106 is done, we can open this PR.

Issues Resolved

Fixes #72

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #68 (592aa16) into main (0ef1995) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #68   +/-   ##
=========================================
  Coverage     84.09%   84.09%           
  Complexity      197      197           
=========================================
  Files            18       18           
  Lines           742      742           
  Branches         90       90           
=========================================
  Hits            624      624           
  Misses           88       88           
  Partials         30       30           

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add something to the developer guide telling people how to use this snapshot to install the extension. Does it publish a .zip?

@owaiskazi19 owaiskazi19 force-pushed the publish-snapshot branch 3 times, most recently from 46ee735 to 9b655e5 Compare October 5, 2023 06:37
@owaiskazi19
Copy link
Member Author

snapshots/
└── org
    └── opensearch
        └── plugin
            └── opensearch-ai-flow-framework
                ├── 3.0.0.0-SNAPSHOT
                │   ├── maven-metadata.xml
                │   ├── maven-metadata.xml.md5
                │   ├── maven-metadata.xml.sha1
                │   ├── maven-metadata.xml.sha256
                │   ├── maven-metadata.xml.sha512
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.pom
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.pom.md5
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.pom.sha1
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.pom.sha256
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.pom.sha512
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.zip
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.zip.md5
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.zip.sha1
                │   ├── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.zip.sha256
                │   └── opensearch-ai-flow-framework-3.0.0.0-20231005.170838-1.zip.sha512
                ├── maven-metadata.xml
                ├── maven-metadata.xml.md5
                ├── maven-metadata.xml.sha1
                ├── maven-metadata.xml.sha256
                └── maven-metadata.xml.sha512

@owaiskazi19 owaiskazi19 force-pushed the publish-snapshot branch 3 times, most recently from 9e5f720 to 1b9d4ee Compare October 5, 2023 17:51
@owaiskazi19 owaiskazi19 changed the title Publish snapshot to maven Publishes snapshot to maven and adds DEV guide Oct 6, 2023
Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small comment

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19 owaiskazi19 merged commit 71123d4 into opensearch-project:main Oct 10, 2023
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
* Publish snapshot to maven

Signed-off-by: Owais Kazi <[email protected]>

* Updated build.gradle file to publish artifacts correctly

Signed-off-by: Owais Kazi <[email protected]>

* Added DEV guide to the repo

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comment

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit 71123d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Oct 10, 2023
Publishes snapshot to maven and adds DEV guide (#68)

* Publish snapshot to maven



* Updated build.gradle file to publish artifacts correctly



* Added DEV guide to the repo



* Addressed PR comment



---------


(cherry picked from commit 71123d4)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Publish SNAPSHOT to Maven
3 participants