Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Ignoring update of final type settings in updateSettings function #1306

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[Backport 2.x] Ignoring update of final type settings in updateSettings function #1306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ open class IndexReplicationTask(id: Long, type: String, action: String, descript
continue
}
val setting = indexScopedSettings[key]
if (!setting.isPrivateIndex) {
if (!setting.isPrivateIndex && !setting.isFinal) {
desiredSettingsBuilder.copy(key, settings);
}
}
Expand All @@ -473,7 +473,7 @@ open class IndexReplicationTask(id: Long, type: String, action: String, descript
if (desiredSettings.get(key) != followerSettings.get(key)) {
//Not intended setting on follower side.
val setting = indexScopedSettings[key]
if (indexScopedSettings.isPrivateSetting(key)) {
if (indexScopedSettings.isPrivateSetting(key) || setting.isFinal) {
continue
}
if (!setting.isDynamic()) {
Expand All @@ -486,7 +486,7 @@ open class IndexReplicationTask(id: Long, type: String, action: String, descript

for (key in followerSettings.keySet()) {
val setting = indexScopedSettings[key]
if (setting == null || setting.isPrivateIndex) {
if (setting == null || setting.isPrivateIndex || setting.isFinal) {
continue
}

Expand Down
Loading