common utils to support Microsoft teams in notifications #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: dankyalo599 <[email protected]>
Signed-off-by: dankyalo599 <[email protected]>
Signed-off-by: dankyalo599 <[email protected]>
…osoft_teams Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
lezzago,
qreshi,
skkosuri-amzn,
bowenlan-amzn,
rishabhmaurya,
tlfeng and
getsaurabh02
as code owners
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
============================================
+ Coverage 74.48% 74.60% +0.12%
- Complexity 859 868 +9
============================================
Files 129 130 +1
Lines 5597 5632 +35
Branches 684 689 +5
============================================
+ Hits 4169 4202 +33
Misses 1124 1124
- Partials 304 306 +2
|
1 task
|
PR in notifications: opensearch-project/notifications#676, opensearch-project/notifications#699 |
1 task
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
|
Hi team, please help review and add backport 2.x label. |
Hailong-am
approved these changes
Aug 9, 2023
|
@opensearch-project/common-utils Could someone help review this PR? Thanks! |
|
Hi @lezzago @qreshi @AWSHurneyt , you contributed many codes to the notifications plugin and are familiar with it. Could you please take a look and help review this PR? Thanks! |
|
@zhichao-aws has this been tested locally with the Notification plugin to ensure the new channel works? |
|
@lezzago Yes, we test the function locally and here are some screenshots:
|
lezzago
approved these changes
Aug 16, 2023
AWSHurneyt
approved these changes
Aug 17, 2023
|
@AWSHurneyt @lezzago could you help to merge it and add backport 2.x label? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Added common utils for microsoft teams Signed-off-by: danielkyalo599 <[email protected]> * Added configType ,eventstatus,configDataProperties and msTeams files Signed-off-by: dankyalo599 <[email protected]> * Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams Signed-off-by: dankyalo599 <[email protected]> * fix build Signed-off-by: zhichao-aws <[email protected]> * fix build, add more test Signed-off-by: zhichao-aws <[email protected]> * change strings import Signed-off-by: zhichao-aws <[email protected]> * fix after core Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: dankyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> (cherry picked from commit bae1bee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Added common utils for microsoft teams * Added configType ,eventstatus,configDataProperties and msTeams files * Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams * fix build * fix build, add more test * change strings import * fix after core --------- (cherry picked from commit bae1bee) Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: dankyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: danielkyalo599 <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…project#428) (opensearch-project#512) * Added common utils for microsoft teams * Added configType ,eventstatus,configDataProperties and msTeams files * Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams * fix build * fix build, add more test * change strings import * fix after core --------- (cherry picked from commit bae1bee) Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: dankyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: danielkyalo599 <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add common utils to support Microsoft teams in notifications plugin
Issues Resolved
opensearch-project/notifications#585
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.