Updating setup-java, byte buddy, jacoco and mockito dependencies #1368
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitgalitz
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
infra
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
============================================
+ Coverage 80.04% 80.10% +0.05%
- Complexity 5667 5675 +8
============================================
Files 533 533
Lines 23438 23438
Branches 2334 2334
============================================
+ Hits 18762 18775 +13
+ Misses 3569 3557 -12
+ Partials 1107 1106 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitgalitz
force-pushed
the
update-coverage
branch
from
3dfbaad
to
2207a1c
Compare
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
force-pushed
the
update-coverage
branch
from
2207a1c
to
1b6cb6e
Compare
| @@ -28,7 +28,7 @@ jobs: | |||
| distribution: temurin # Temurin is a distribution of adoptium | |||
| java-version: 21 | |||
| - uses: actions/checkout@v4 | |||
| - uses: aws-actions/[email protected].1 | |||
| - uses: aws-actions/[email protected].2 | |||
There was a problem hiding this comment.
Suggest just use v4 instead of specific version unless you have specific requirements here.
Thanks!
There was a problem hiding this comment.
We keep getting depandabot PRs for this, do you know why we are getting this and other repos aren't? #1182
There was a problem hiding this comment.
If you use v4 it will automatically link to the latest v4.x.x.
ohltyler
approved these changes
Nov 18, 2024
joshpalis
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating several different dependencies that we have outdated depandabot PRs for.
Also testing out this solution for some of our workflows that still have checkout@v3.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.