delete query index only if put mappings throws an exception #1685
Conversation
Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
requested review from
lezzago,
AWSHurneyt,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn,
jowg-amazon,
amsiglan and
goyamegh
as code owners
Signed-off-by: Subhobrata Dey <[email protected]>
| indexTimeout = indexTimeout | ||
| ) | ||
| } catch (e: Exception) { | ||
| log.debug("unknown exception during PUT mapping on queryIndex: $targetQueryIndex") |
There was a problem hiding this comment.
always log the exception
log.debug("Doc level monitor $monitorId: unknown exception during PUT mapping on queryIndex: $targetQueryIndex", e)
There was a problem hiding this comment.
in AlertingException class plz add first line logging error so that if we miss here we wont eat up stacktrace..right now debugging is tough as stacktrace and message is not descriptive due to lack of logging
There was a problem hiding this comment.
AlertingException class resides in common-utils. logged the exception.
| val unwrappedException = ExceptionsHelper.unwrapCause(e) as Exception | ||
| throw AlertingException.wrap(unwrappedException) | ||
| // retry with deleting query index | ||
| if (monitor.deleteQueryIndexInEveryRun == true && docLevelQueryIndexExists(monitor.dataSources)) { |
There was a problem hiding this comment.
we should check doc level query exsits or not only for deletion not for creation of new index
can we remove index exists check here and add only before trying deleteDocLevelQueryIndex(..)
what if query doesnt exist and exception was index not found
| // retry with deleting query index | ||
| if (monitor.deleteQueryIndexInEveryRun == true && docLevelQueryIndexExists(monitor.dataSources)) { | ||
| try { | ||
| log.info( |
There was a problem hiding this comment.
split into error log and plz log exception
Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 6239d7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 6239d7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.17
# Create a new branch
git switch --create backport-1685-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6239d7b665a98efcee7a1001e12a215d9ed53be4
# Push it to GitHub
git push --set-upstream origin backport-1685-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.17Then, create a pull request where the |
…1690) (cherry picked from commit 6239d7b) Signed-off-by: Subhobrata Dey <[email protected]>
…1691) (cherry picked from commit 6239d7b) Signed-off-by: Subhobrata Dey <[email protected]>
…ch-project#1685) (opensearch-project#1690) (cherry picked from commit 6239d7b) Signed-off-by: Subhobrata Dey <[email protected]>
Description
delete query index only if put mappings throws an exception
continue from #1674
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.