suppress optional callback exception #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
requested review from
lezzago,
AWSHurneyt,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
============================================
+ Coverage 67.60% 67.75% +0.15%
Complexity 105 105
============================================
Files 160 160
Lines 10343 10343
Branches 1522 1522
============================================
+ Hits 6992 7008 +16
+ Misses 2686 2672 -14
+ Partials 665 663 -2
|
eirsep
approved these changes
Aug 10, 2023
lezzago
reviewed
Aug 10, 2023
| @@ -454,7 +454,7 @@ object DocumentLevelMonitorRunner : MonitorRunner() { | |||
| publishFinding(monitor, monitorCtx, finding) | |||
| } catch (e: Exception) { | |||
| // suppress exception | |||
| logger.error("Optional finding callback failed", e) | |||
| logger.info("Optional finding callback failed: ${e.message}") | |||
There was a problem hiding this comment.
Should this be changed to debug? This would occur every time a doc level monitor is running even if the user never using security analytics plugin as its currently the only plugin to use this.
Signed-off-by: Subhobrata Dey <[email protected]>
lezzago
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
suppress optional callback exception
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.