Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed refresh policy from IMMEDIATE TO WAIT_UNTIL in Alert Service class #1075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Aug 2, 2023

Although there are many other instances of Refresh Policy IMMEDIATE being used in persisting various resources in alerting plugin, Indexing alerts is one aspect which requires the WAIT_UNTIL refresh policy to be set because chained alert triggers rely on availability of AUDIT alerts.

Hence I am making a change only in this class. Other instances of refresh policy changes will need to be evaluated and taken up in a separate PR.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1075 (d20d01e) into main (09911d2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1075      +/-   ##
============================================
+ Coverage     67.71%   67.75%   +0.03%     
  Complexity      105      105              
============================================
  Files           160      160              
  Lines         10343    10343              
  Branches       1522     1522              
============================================
+ Hits           7004     7008       +4     
+ Misses         2674     2669       -5     
- Partials        665      666       +1     
Files Changed Coverage Δ
...ain/kotlin/org/opensearch/alerting/AlertService.kt 81.58% <100.00%> (ø)

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.9 backports PRs to 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants