-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set httpcore5 to 5.2 to be compatible with httpclient5 5.2.1 #8503
Conversation
Signed-off-by: Craig Perkins <[email protected]>
@reta There were issues in the SDK related to the httpcore5 update to 5.2.2 so I created a PR to set it to 5.2 which is compatible with httpclient:5.2.1. I created another PR in opensearch-java too: opensearch-project/opensearch-java#566 |
Signed-off-by: Craig Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Unless @reta has anything for downgrading the version.
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8503 +/- ##
============================================
- Coverage 70.90% 70.87% -0.03%
- Complexity 56903 56922 +19
============================================
Files 4758 4758
Lines 269225 269227 +2
Branches 39407 39402 -5
============================================
- Hits 190881 190826 -55
+ Misses 62256 62251 -5
- Partials 16088 16150 +62
|
Gradle Check (Jenkins) Run Completed with:
|
Isn't the fix to upgrade httpcore to 5.2.2? |
@dblock Looking at the source code for HttpClient5:5.2.1, it references HttpCore5:5.2 not HttpCore5:5.2.2 This isn't the case with HttpClient5:4.5.14 which references HttpCore5:4.4.16 |
We use 5.2.2 explicitly, the transient 5.2 dependency from HttpClient5 should not be used:
|
Fix is sent to opensearch-project/opensearch-sdk-java#861 |
Thank you @reta ! Closing this PR. |
For the record,
|
Description
org.apache.httpcomponents.client5:httpclient5:5.2.1
is compatible with httpcore5:5.2 and the recent upgrade to 5.2.2 is causing problems running an extension using the SDK. I am opening a PR to downgrade the version to 5.2 which is compatible with httpclient:5.2.1Issues Resolved
opensearch-project/opensearch-sdk-java#857
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.