Add BulkShardRequest Serialization Test #17057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jchrys <[email protected]>
jchrys
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17057 +/- ##
============================================
- Coverage 72.23% 72.19% -0.04%
- Complexity 65292 65305 +13
============================================
Files 5301 5301
Lines 303823 303823
Branches 44033 44033
============================================
- Hits 219454 219335 -119
- Misses 66344 66508 +164
+ Partials 18025 17980 -45 ☔ View full report in Codecov by Sentry. |
|
@jchrys Thanks for the contribution! Just curious, what's the reason for adding this test? I'm all for better tests, just wondering if there was a related bug or problem that motivated this change. |
|
@andrross |
andrross
approved these changes
Jan 22, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Signed-off-by: jchrys <[email protected]> (cherry picked from commit 7977446) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Jan 22, 2025
(cherry picked from commit 7977446) Signed-off-by: jchrys <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add BulkShardRequest Serialization Test
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.