[Backport 2.x] Adds cluster setting to allow caching requests with size>0 in request cache #16540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… cache (#16484) * Add cluster setting to allow size>0 in request cache Signed-off-by: Peter Alfonsi <[email protected]> * Add to changelog Signed-off-by: Peter Alfonsi <[email protected]> * addressed dbwiddis's comments Signed-off-by: Peter Alfonsi <[email protected]> * make canCacheSizeNonzeroRequests volatile Signed-off-by: Peter Alfonsi <[email protected]> * fix changelog merge Signed-off-by: Peter Alfonsi <[email protected]> * Changed setting name Signed-off-by: Peter Alfonsi <[email protected]> * more renaming Signed-off-by: Peter Alfonsi <[email protected]> * fix spotless check Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle check Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> (cherry picked from commit 0363aa7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
dbwiddis
approved these changes
Nov 1, 2024
|
❌ Gradle check result for a87a209: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a87a209: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16540 +/- ##
============================================
- Coverage 71.90% 71.77% -0.14%
+ Complexity 65421 65375 -46
============================================
Files 5312 5312
Lines 305004 305009 +5
Branches 44440 44440
============================================
- Hits 219319 218919 -400
- Misses 67401 67852 +451
+ Partials 18284 18238 -46 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0363aa7 from #16484.