-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new configuration setting synonym_analyzer
for synonym_graph
and synonym
.
#16488
Add a new configuration setting synonym_analyzer
for synonym_graph
and synonym
.
#16488
Conversation
❌ Gradle check result for fb66d0f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...analysis-common/src/main/java/org/opensearch/analysis/common/CommonAnalysisModulePlugin.java
Outdated
Show resolved
Hide resolved
fb66d0f
to
550756f
Compare
❌ Gradle check result for 550756f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
550756f
to
7a5c00e
Compare
❌ Gradle check result for 7a5c00e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7a5c00e
to
17737cf
Compare
❌ Gradle check result for 17737cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Prudhvi Godithi <[email protected]>
17737cf
to
0332408
Compare
❌ Gradle check result for 0332408: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
458ce70
to
6feda4b
Compare
.../analysis-common/src/main/java/org/opensearch/analysis/common/SynonymTokenFilterFactory.java
Outdated
Show resolved
Hide resolved
...analysis-common/src/main/java/org/opensearch/analysis/common/CommonAnalysisModulePlugin.java
Outdated
Show resolved
Hide resolved
db57995
to
84de9dc
Compare
Signed-off-by: Prudhvi Godithi <[email protected]>
84de9dc
to
7d6fc43
Compare
Signed-off-by: Prudhvi Godithi <[email protected]>
Hey @msfroh I just pushed a commit to fix the |
❌ Gradle check result for 0c33516: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I have re-triggered the Gradle check, the failure is due to the flaky tests coming from MinimumClusterManagerNodesIT. The existing automation should link this PR to the existing Flaky Test Report for MinimumClusterManagerNodesIT. |
❌ Gradle check result for 0c33516: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Prudhvi Godithi <[email protected]>
0c33516
to
5411897
Compare
❌ Gradle check result for 5411897: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16488-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5068fad53922f992ef651f78c148df6d9170c361
# Push it to GitHub
git push --set-upstream origin backport/backport-16488-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Description
Coming from #16263 (comment) this PR is not final and still need some discussion.
Related Issues
Part of #16263 and #16530.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.