Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for restoring from snapshot with search replicas #16111

Merged
merged 12 commits into from
Oct 23, 2024

Conversation

vinaykpud
Copy link
Contributor

Description

In this PR we are adding,

  1. Support for restoring search replicas from a snapshot taken with search replica
  2. Add validations to ensure compatibility between DOCUMENT and SEGMENT replication type while snapshot restoration. Following are the allowed rules:
  • Snapshots taken when the replication type is DOCUMENT can be restored to DOCUMENT or SEGMENT types. If we are restoring to SEGMENT type more search replicas can be added.
  • Snapshots taken when the replication type is SEGMENT and without any search replicas can be restored to DOCUMENT or SEGMENT types. If we are restoring to SEGMENT type more search replicas can be added.
  • Snapshots taken when the replication type is SEGMENT and with search replicas can be restored to DOCUMENT or SEGMENT types. If we are restoring to SEGMENT type more search replicas can be added. If we are restoring to DOCUMENT type search replica count must be set to 0 in the settings.

Related Issues

Resolves #15532
Related #15306

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 7556720: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 2, 2024

❌ Gradle check result for 7f03249: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ca2fd04: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mch2
Copy link
Member

mch2 commented Oct 22, 2024

❌ Gradle check result for ca2fd04: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#15812

Copy link
Contributor

❌ Gradle check result for ca2fd04: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 24d02df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 24d02df: SUCCESS

Copy link
Contributor

✅ Gradle check result for 9824b93: SUCCESS

@mch2 mch2 merged commit 9dd1a59 into opensearch-project:main Oct 23, 2024
37 of 38 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16111-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9dd1a59847ad8c2716d002716521ac40afc69355
# Push it to GitHub
git push --set-upstream origin backport/backport-16111-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16111-to-2.x.

vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 24, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 24, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Oct 25, 2024
mch2 pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed v2.18.0 Issues and PRs related to version 2.18.0
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[RW Separation] Updates to restore from snapshot with added search replicas
2 participants