Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit to support a search only replica for RW separation. #15410

Merged
merged 13 commits into from
Aug 30, 2024
Merged

Initial commit to support a search only replica for RW separation. #15410

merged 13 commits into from
Aug 30, 2024

Commits on Aug 26, 2024

  1. Initial commit for search only replica. 

    This PR contains the following:
1. Introduce searchOnly flag on ShardRouting.
2. Added feature flag to enable/disable the feature.
3. supports both create and update APIs to toggle search replica count.
4. Changes to exclude search replicas from primary eligibility.
5. Changes to prevent replicationOperations from routing to search replicas.

Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b257d86 View commit details
    Browse the repository at this point in the history

  2. add some missing feature flag checks 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e448e1f View commit details
    Browse the repository at this point in the history

  3. Pr feedback from @andrross 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2caa87f View commit details
    Browse the repository at this point in the history

  4. Add more unit tests for settings create and update 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9c54a4e View commit details
    Browse the repository at this point in the history

  5. Fix broken tests from setting rename 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b1938d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Fix broken tests and add changelog entry 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c059bd8 View commit details
    Browse the repository at this point in the history

  2. More PR feedback. 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6e563e5 View commit details
    Browse the repository at this point in the history

  3. add missing searchOnly property to initializeTargetRelocatingShard. 

    Without this search replicas will become regular replicas on relocation.

Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ea24458 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'main' into split 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a42af7e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. test fixes 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c5d29a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into split 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e182c9e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'main' into split

    @mch2
    mch2 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    612c2c3 View commit details
    Browse the repository at this point in the history

  2. spotless 

    Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2207a10 View commit details
    Browse the repository at this point in the history