Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky test] Clear transient cluster setting at the end of the test #13508

Merged
merged 1 commit into from
May 3, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented May 2, 2024

Description

Clear transient cluster setting at the end of the test to ensure test clean up doesn't fail

Remove check of non zero assertion of time as it is non deterministic

Related Issues

Resolves #11179 , #11221

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the flaky-test Random test failure that succeeds on second run label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for b580023: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for 0a40e2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for b580023: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

andrross commented May 2, 2024

❌ Gradle check result for b580023: FAILURE

#12639

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for 0a40e2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for b580023: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19
Copy link
Member

@gbbafna looks like Spotless is complaining. Can you please format and push again?

Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for 2f8ff13: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for 2f8ff13: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Remove check of non zero assertion of time as it is non deterministic
Signed-off-by: Gaurav Bafna <[email protected]>
Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for 24d986c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 3, 2024

❕ Gradle check result for 24d986c: UNSTABLE

  • TEST FAILURES:
      3 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.55%. Comparing base (b15cb0c) to head (24d986c).
Report is 260 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13508      +/-   ##
============================================
+ Coverage     71.42%   71.55%   +0.13%     
- Complexity    59978    61086    +1108     
============================================
  Files          4985     5051      +66     
  Lines        282275   287119    +4844     
  Branches      40946    41602     +656     
============================================
+ Hits         201603   205452    +3849     
- Misses        63999    64675     +676     
- Partials      16673    16992     +319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 89c6c27 into opensearch-project:main May 3, 2024
28 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label May 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
Remove check of non zero assertion of time as it is non deterministic
Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit 89c6c27)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request May 3, 2024
Remove check of non zero assertion of time as it is non deterministic

Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit 89c6c27)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
…oject#13508)

Remove check of non zero assertion of time as it is non deterministic
Signed-off-by: Gaurav Bafna <[email protected]>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…oject#13508)

Remove check of non zero assertion of time as it is non deterministic
Signed-off-by: Gaurav Bafna <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…oject#13508)

Remove check of non zero assertion of time as it is non deterministic
Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.action.admin.indices.create.RemoteCloneIndexIT.testCreateCloneIndex is flaky
4 participants