Skip to content

Commit

Permalink
[Backport 2.x] [Derived Fields] Add aggregation support for derived f…
Browse files Browse the repository at this point in the history
…ields (#15009)

* [Derived Fields] Add aggregation support for derived fields (#14618)

* Add aggregation support for derived fields

Signed-off-by: Marc Handalian <[email protected]>

* add unit test for a terms agg with derived fields

Signed-off-by: Marc Handalian <[email protected]>

* Fix license header and add changelog entry

Signed-off-by: Marc Handalian <[email protected]>

* move matrix_stats tests to aggs-matrix-stats module

Signed-off-by: Marc Handalian <[email protected]>

* Move matrix tests back and add dependency to painless module

Signed-off-by: Marc Handalian <[email protected]>

* add tests for all aggregations types and support ip_range

Signed-off-by: Marc Handalian <[email protected]>

* Add tests for agg script returned from DerivedFieldType

Signed-off-by: Marc Handalian <[email protected]>

* remove children aggs test as its not yet supported

Signed-off-by: Marc Handalian <[email protected]>

* Add more tests

Signed-off-by: Marc Handalian <[email protected]>

* fix changelog

Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
(cherry picked from commit e26608b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix derived field tests for percentile ranks. (#15015)

These tests fail to backport to 2.x becuase 2.x uses a different branch of
tdigest that computes percentiles differently.  Rather than chase these over time,
change the assertions to check for the length of results returned instead of their values.

Signed-off-by: Marc Handalian <[email protected]>
(cherry picked from commit 0cde7ba)
Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marc Handalian <[email protected]>
  • Loading branch information
3 people authored Jul 30, 2024
1 parent fdd3ea7 commit 4b44592
Show file tree
Hide file tree
Showing 10 changed files with 1,883 additions and 10 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
## [Unreleased 2.x]
### Added
- Fix for hasInitiatedFetching to fix allocation explain and manual reroute APIs (([#14972](https://github.com/opensearch-project/OpenSearch/pull/14972))
- Add basic aggregation support for derived fields ([#14618](https://github.com/opensearch-project/OpenSearch/pull/14618))

### Dependencies
- Bump `org.apache.commons:commons-lang3` from 3.14.0 to 3.15.0 ([#14861](https://github.com/opensearch-project/OpenSearch/pull/14861))
Expand Down
1 change: 1 addition & 0 deletions modules/lang-painless/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ ext {

testClusters.all {
module ':modules:mapper-extras'
module ':modules:aggs-matrix-stats'
systemProperty 'opensearch.scripting.update.ctx_in_params', 'false'
// TODO: remove this once cname is prepended to transport.publish_address by default in 8.0
systemProperty 'opensearch.transport.cname_in_publish_address', 'true'
Expand Down
Loading

0 comments on commit 4b44592

Please sign in to comment.