-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db resolver #185
Draft
jbothma
wants to merge
21
commits into
main
Choose a base branch
from
jdb/db-resolver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
db resolver #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbothma
commented
Jan 9, 2025
jbothma
commented
Jan 17, 2025
engine: Engine, | ||
metadata: MetaData, | ||
create: bool = False, | ||
table_name: str = "resolver", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basic configurable table name test
jbothma
commented
Jan 17, 2025
How do we feel about having soft delete on the resolver (next week!!!!) |
jbothma
commented
Jan 20, 2025
jbothma
commented
Jan 20, 2025
jbothma
force-pushed
the
jdb/db-resolver
branch
from
January 30, 2025 17:24
4f228bd
to
c4fd405
Compare
jbothma
force-pushed
the
jdb/db-resolver
branch
from
January 30, 2025 18:38
c4fd405
to
9369cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super rough port so far, with connection passed as arg for external transaction control