Create a management form component #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomodwyer
force-pushed
the
managment-form
branch
4 times, most recently
from
cfaa59b to
ca775b6
Compare
Jongmassey
approved these changes
Jan 20, 2025
tomodwyer
force-pushed
the
managment-form
branch
from
ca775b6 to
65d8e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #2249 as part of a tidying up process before conversion to TypeScript.
This PR moves the management form out of the main CodelistBuilder class, and creates it as it's own functional component. This allows the form to use React hooks for state management, and moves the calculation of the codelist completion inside the component.
This simplifies the logic for showing the discard modal, and removes the need for the top-level
renderConfirmDiscardModalcomponent.