Refactor csv download code for mapped VMPs #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaindillingham
approved these changes
Oct 31, 2023
| if previous_vmp not in prev_to_vmp_mapping: | ||
| prev_to_vmp_mapping[previous_vmp] = vmp | ||
| # mapping in a previous code | ||
| previous_vmps_to_add.setdefault(previous, []).append(vmp) |
There was a problem hiding this comment.
I'd have reached for collections.defaultdict here. I didn't know about dict.setdefault 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered another small bug in how the mapped VMP descriptions were produced, and realised that the previous code was ridiculously overcomplicated. The first commit refactors the way the mapped-VMP descriptions are generated, the second one removed the extra code that was only there for the overcomplicated previous version.