Allow release file reuploads to different workspaces #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuploads of the same release file (with same filename and same content) are prohibited. However, a file with the same name/content may legitimately be reuploaded to a different workspace. Update the check for already uploaded files to check for the same filename/content within the target workspace only.
rebkwok
force-pushed
the
release-file-reuploads
branch
from
826f6ea to
d3912b6
Compare
bloodearnest
approved these changes
Jan 14, 2025
| @@ -93,20 +94,51 @@ def test_create_release_reupload(): | |||
| "url": "", | |||
| "size": 4, | |||
| "sha256": "hash", | |||
| "mtime": "2022-08-17T13:37Z", | |||
There was a problem hiding this comment.
huh, how was this working before?
There was a problem hiding this comment.
I think it's because it never got that far - it would fail the reupload before it tried to access the date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuploads of the same release file (with same filename and same content) are prohibited. However, a file with the same name/content may legitimately be reuploaded to a different workspace. Update the check for already uploaded files to check for the same filename/content within the target workspace only.
See slack thread