Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assertions in dummy data specialize() #2350

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix assertions in dummy data specialize() #2350

merged 1 commit into from
Jan 13, 2025

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Jan 10, 2025 •
edited
Loading

@rebkwok rebkwok force-pushed the dummy-data-specialize branch 2 times, most recently from 9a56cae to acf90d3 Compare January 10, 2025 15:52
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2025 •
edited
Loading

Deploying databuilder-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80d0d5a
Status: ✅  Deploy successful!
Preview URL: https://ebdaaed6.databuilder.pages.dev
Branch Preview URL: https://dummy-data-specialize.databuilder.pages.dev

View logs

@rebkwok rebkwok force-pushed the dummy-data-specialize branch from acf90d3 to 13ddf08 Compare January 13, 2025 09:50
@rebkwok rebkwok marked this pull request as ready for review January 13, 2025 09:53
@rebkwok rebkwok changed the title test and not-quite-right fix for assertion error in specialize() fix for assertions in dummy data specialize() Jan 13, 2025
@rebkwok rebkwok changed the title fix for assertions in dummy data specialize() fix assertions in dummy data specialize() Jan 13, 2025
evansd
evansd approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@evansd evansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I don't think we need to wait for David's response before merging, although I still think it's worthwhile checking our reasoning with him.

Also, very sadly, you're going to need a pedantic commit prefix here to actually get the fix out :(

@rebkwok rebkwok force-pushed the dummy-data-specialize branch from 13ddf08 to 80d0d5a Compare January 13, 2025 10:17
@rebkwok rebkwok merged commit f25ca12 into main Jan 13, 2025
8 checks passed
@rebkwok rebkwok deleted the dummy-data-specialize branch January 13, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansd evansd evansd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebkwok @evansd