fix: Fix workflow permissions #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Github docs, a "permissive" Github token (which is what we have) has "package: write" permissions by default: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token And also according the Github docs, if you explicitly specify _any_ permission in the workflow flow then all permissions you haven't specified revert to `none`: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#defining-access-for-the-github_token-scopes This means that explictly including `package: write` as we were doing is not only unnecessary but prevents us having permission to push version tags, meaning that the `tag-new-version` action failed with: Error: Resource not accessible by integration Obviously Github's behaviour must have changed here because this did work successfully on 2023-08-01, which was when we last published a new version.
bloodearnest
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Github docs, a "permissive" Github token (which is what we have) has "package: write" permissions by default: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
And also according the Github docs, if you explicitly specify any permission in the workflow flow then all permissions you haven't specified revert to
none:https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#defining-access-for-the-github_token-scopes
This means that explictly including
package: writeas we were doing is not only unnecessary but prevents us having permission to push version tags, meaning that thetag-new-versionaction failed with:Obviously Github's behaviour must have changed here because this did work successfully on 2023-08-01, which was when we last published a new version.