Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated open issues popup styling #94

Merged
merged 2 commits into from
May 25, 2023

Conversation

Bubo101
Copy link
Contributor

@Bubo101 Bubo101 commented May 24, 2023

Added counter
Changed label color to black for better visibility
Centered and enlarged headings

Copy link
Member

@natebass natebass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, my first impression was that the font is slightly too big. I'm 50/50 on the counter numbers being that useful, but I'm OK with keeping them because the page is pretty sparse so it spices it up a bit.

css/style.css Show resolved Hide resolved
css/style.css Outdated

.issues-title {

font-size: 4rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title looks slightly too big, to me at least. What about deleting this font-size: 4rem; so that the Issue title reverts to <h3>'s default size of 34px? 34px also matches the title for each row of projects on the page behind this modal, so it stays consistent with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I removed that styling.

@Bubo101 Bubo101 requested a review from natebass May 25, 2023 00:44
@natebass natebass merged commit 9e574e8 into opensacorg:gh-pages May 25, 2023
@natebass
Copy link
Member

Related to Issue #71 Add styling to projects page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants