Fix issue parsing string with Java8ReloadableParser #4914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Revert the
Java8ReloadableParser
to useJavaCompiler.parse()
instead ofJavaCompiler.parseFiles()
to support parsing strings as input. This issue does not occur with other versions of the Java parser.What's your motivation?
Recent changes to
Java8ReloadableParser
caused the following error in our custom recipes:This occurs when we attempt to parse a file from a string input:
Anyone you would like to review specifically?
@timtebeek
Any additional context
I would like to add a unit test for this, but I have not been able to figure out how to make calls to
JavaParser.fromJavaVersion().build().parse()
using Java 8 within the unit testing framework. Any assistance with this would be appreciated. I have confirmed this change fixes our recipes through end-to-end testing.Checklist