Fixing the quoteEscaping test case for proper quote character escaping #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixing the recently added (#4616) test case called
quoteEscapingin HCL handling.As is, the test runs rewrite against an invalid HCL fail and fails (as noted by
@ExpectedToFail). Thus, fixing the tested HCL syntax, observing the test pass (with no code changes) and removing the@ExpectedToFailannotation.Closes #4612.
What's your motivation?
Fix the bug in tests.
Anyone you would like to review specifically?
@timtebeek was the one to look at it before