Jmockit mockito full verifications and Refactor tests #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
shivanisky
changed the title
sambsnyd
reviewed
Oct 22, 2024
Comment on lines
+23
to
+29
| class JMockitTestBase implements RewriteTest { | ||
|
|
||
| @Override | ||
| public void defaults(RecipeSpec spec) { | ||
| setDefaultParserSettings(spec); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would prefer not to create a base class just to share a single method invocation's worth of configuration. Single inheritance of JMockitTestBase limits the ability of tests to extend other base classes for little code reuse. I would prefer to have setDefaultParserSettings() called explicitly in the defaults method of each individual test class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Migrate JMockit FullVerifications to Mockito
https://www.javadoc.io/doc/org.jmockit/jmockit/latest/mockit/FullVerifications.html
https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html <- for verifyNoMoreInteractions
Replacing FullVerifications with standard mockito verify and then add one line of verifyNoMoreInteractions(mocks. ..)
Also do a refactor of tests to remove some unnecessary code - add a new JMockitTestBase which sets the default parser settings and other tests can inherit from that, hope it's ok to use inhertance here, if not please let me know. I think it makes a lot of sense here.
What's your motivation?
Just wanted to add this feature to enhance the current migration scope, InOrderVerifications feature was requested here jmockit/jmockit1#729 (comment) and this will also help pave the way for that
Anyone you would like to review specifically?
@timtebeek @tinder-dthomson as FYI, and if wants to review also (I know he is busy)
Checklist