Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMockit's MockUp to Mockito migration #599
Add JMockit's MockUp to Mockito migration #599
Changes from 8 commits
b31f293
1da4931
4e42b59
faa1bb1
6d92ade
96688de
f9d9fa1
694f1f0
78a4aae
cda1e64
4589bb3
c90fb67
7c7fecc
8a71eb8
f9827b0
34589a0
e03719a
6c9d156
3fd7446
162352f
a852a60
c9f8280
4ef5811
ac83863
e41c20d
08f3f60
8992a87
dce23c8
e691a7b
4eeae91
ee06b6e
f06d8b0
a9fc1bc
9f814cb
f1de48c
f987e59
28485bb
fc25bbd
199f8f7
fa85adb
8391a98
b61496d
d9eb4a8
0dc4d10
1e5b465
b4f1e0a
ad0c387
750a45b
b5b1c08
84638a3
29ab5c4
1edb46d
fc89a16
43d771f
91e9814
3e81e45
361cfc4
5d81b5d
659831c
a4ec846
3c513bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a look at the overall design, I'm wondering if it would be much better to reuse the existing code in JMockitBlockToMockito, and add MockUp in the Preconditions, and then in JMockitBlockRewriter if the block type is a mockup, call much of the code of this class to rewrite the method by passing the the block, visitor and context. This however, would make it difficult to handle tearing down of any mock constructors if the teardown method is before the setup method so possibly a two cycle recipe would be needed, however it would probably reduce the number of lines of code due to the reuse.
Also build needs to be green before submitting for review as the main build is green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be too complicated integrating mockUp into JMockitBlockToMockito?
I can see the tests of PowerMockitoMockStaticToMockitoTest and other recipes failed and cause the build red.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cloned the latest code in main and built. Those cases are failed too. @timtebeek are they expected?