-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jmockit Expectations - Handle Additional Cases #418
Jmockit Expectations - Handle Additional Cases #418
Conversation
Thanks for this improvement already! Would you want to continue to iterate in this pull request? Or can we merge the existing work and follow up in a subsequent PR? |
I'm okay with iterate PRs, since this will take some time to cover all cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for these improvements already, we can indeed iterate in a follow up PR; We'll get this merged and released already.
What's changed?
J.MethodDeclaration
instead ofJ.NewClass
. When attempting to substitute theJ.NewClass
with multipleJ.MethodDeclaration
LSTs, the old recipe would fail.What's your motivation?
Continuation of #415.
This is still an incomplete implementation, but now handles multiple expectations defined within a JMockit
Expectations
block.Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew licenseFormat