Suppress mutable execution context warnings for now (#668)

- Following openrewrite/rewrite#4879
openrewrite · Jan 17, 2025 · 3018587 · 3018587
1 parent 7c52792
commit 3018587
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/src/main/java/org/openrewrite/java/testing/hamcrest/RemoveNotMatcherVisitor.java b/src/main/java/org/openrewrite/java/testing/hamcrest/RemoveNotMatcherVisitor.java
@@ -64,12 +64,12 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation mi, Execution
                 result = template.apply(getCursor(), mi.getCoordinates().replace(), mi.getArguments().get(0));
             }
 
-            ctx.putMessage(result.toString(), !logicalContext);
+            ctx.putMessage(result.toString(), !logicalContext); // FIXME Do not store on the use execution context
 
             return result;
         } else {
             if (ctx.pollMessage(mi.toString()) == null) {
-                ctx.putMessage(mi.toString(), true);
+                ctx.putMessage(mi.toString(), true); // FIXME Do not store on the use execution context
             }
         }
         return super.visitMethodInvocation(mi, ctx);

diff --git a/src/test/java/org/openrewrite/java/testing/hamcrest/HamcrestInstanceOfToJUnit5Test.java b/src/test/java/org/openrewrite/java/testing/hamcrest/HamcrestInstanceOfToJUnit5Test.java
@@ -23,14 +23,16 @@
 import org.openrewrite.test.RewriteTest;
 
 import static org.openrewrite.java.Assertions.java;
+import static org.openrewrite.test.TypeValidation.all;
 
 class HamcrestInstanceOfToJUnit5Test implements RewriteTest {
     @Override
     public void defaults(RecipeSpec spec) {
         spec
           .parser(JavaParser.fromJavaVersion()
             .classpathFromResources(new InMemoryExecutionContext(), "junit-jupiter-api-5.9", "hamcrest-2.2"))
-          .recipe(new HamcrestInstanceOfToJUnit5());
+          .recipe(new HamcrestInstanceOfToJUnit5())
+          .typeValidationOptions(all().immutableExecutionContext(false));
     }
 
     @DocumentExample

diff --git a/src/test/java/org/openrewrite/java/testing/hamcrest/HamcrestMatcherToJUnit5Test.java b/src/test/java/org/openrewrite/java/testing/hamcrest/HamcrestMatcherToJUnit5Test.java
@@ -23,6 +23,7 @@
 import org.openrewrite.test.RewriteTest;
 
 import static org.openrewrite.java.Assertions.java;
+import static org.openrewrite.test.TypeValidation.all;
 
 class HamcrestMatcherToJUnit5Test implements RewriteTest {
     @Override
@@ -122,6 +123,7 @@ void testEquals() {
     void notEqualToString() {
         //language=java
         rewriteRun(
+          spec -> spec.typeValidationOptions(all().immutableExecutionContext(false)),
           java(
             """
               import org.junit.jupiter.api.Test;
@@ -464,6 +466,7 @@ void testNullValue() {
     void sameInstance() {
         //language=java
         rewriteRun(
+          spec -> spec.typeValidationOptions(all().immutableExecutionContext(false)),
           java(
             """
               import org.junit.jupiter.api.Test;

diff --git a/src/test/java/org/openrewrite/java/testing/hamcrest/MigrateHamcrestToJUnitTest.java b/src/test/java/org/openrewrite/java/testing/hamcrest/MigrateHamcrestToJUnitTest.java
@@ -23,6 +23,7 @@
 import org.openrewrite.test.RewriteTest;
 
 import static org.openrewrite.java.Assertions.java;
+import static org.openrewrite.test.TypeValidation.all;
 
 class MigrateHamcrestToJUnitTest implements RewriteTest {
     @Override
@@ -38,6 +39,7 @@ public void defaults(RecipeSpec spec) {
     void equalToString() {
         //language=java
         rewriteRun(
+          spec -> spec.typeValidationOptions(all().immutableExecutionContext(false)),
           java(
             """
               import org.junit.jupiter.api.Test;

diff --git a/src/test/java/org/openrewrite/java/testing/hamcrest/RemoveNotMatcherTest.java b/src/test/java/org/openrewrite/java/testing/hamcrest/RemoveNotMatcherTest.java
@@ -24,17 +24,20 @@
 
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.test.RewriteTest.toRecipe;
+import static org.openrewrite.test.TypeValidation.all;
 
 class RemoveNotMatcherTest implements RewriteTest {
     @Override
     public void defaults(RecipeSpec spec) {
         spec
           .parser(JavaParser.fromJavaVersion()
             .classpathFromResources(new InMemoryExecutionContext(), "junit-jupiter-api-5.9", "hamcrest-2.2"))
-          .recipe(toRecipe(RemoveNotMatcherVisitor::new));
+          .recipe(toRecipe(RemoveNotMatcherVisitor::new))
+          .typeValidationOptions(all().immutableExecutionContext(false));
     }
 
     @DocumentExample
+    @Test
     void nestedNotMatcher() {
         rewriteRun(
           //language=java