Drop now unnecessary SimplifyConstantTernaryExecution

Following openrewrite/rewrite#4617
openrewrite · Oct 27, 2024 · ee9fc7b · ee9fc7b
1 parent c81972d
commit ee9fc7b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 154 deletions.
diff --git a/src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java b/src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java
@@ -31,6 +31,7 @@
 import java.util.Set;
 
 import static org.openrewrite.java.template.internal.AbstractRefasterJavaVisitor.EmbeddingOption.SHORTEN_NAMES;
+import static org.openrewrite.java.template.internal.AbstractRefasterJavaVisitor.EmbeddingOption.SIMPLIFY_BOOLEANS;
 
 public class BufferedWriterCreation extends Recipe {
 
@@ -139,13 +140,12 @@ public J visitNewClass(J.NewClass elem, ExecutionContext ctx) {
                 JavaTemplate.Matcher matcher;
                 if ((matcher = before.matcher(getCursor())).find()) {
                     maybeRemoveImport("java.io.FileWriter");
-                    J j = embed(
+                    return embed(
                             after.apply(getCursor(), elem.getCoordinates().replace(), matcher.parameter(0), matcher.parameter(1)),
                             getCursor(),
                             ctx,
-                            SHORTEN_NAMES
+                            SHORTEN_NAMES, SIMPLIFY_BOOLEANS
                     );
-                    return (J) new SimplifyConstantTernaryExecution().getVisitor().visitNonNull(j, ctx, getCursor().getParentOrThrow());
                 }
                 return null;
             }

diff --git a/src/main/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecution.java b/src/main/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecution.java
diff --git a/src/test/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecutionTest.java b/src/test/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecutionTest.java