Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the old runtime Spring Core dependency brought in through spring-data-mongodb:2.+ #626

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

timtebeek
Copy link
Contributor

As that's blocked due to vulnerabilities in some places, but was proving troublesome when installing recipes jars if the excluded dependency poms can not be found. This seemed the quickest way forward after also exploring the downloads in openrewrite/rewrite but finding no easy way forward there.

As that's blocked due to vulnerabilities in some places.
@timtebeek timtebeek self-assigned this Nov 14, 2024
@timtebeek timtebeek added the enhancement New feature or request label Nov 14, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/data/RefactorSimpleMongoDbFactory.java
    • lines 74-74

@timtebeek
Copy link
Contributor Author

@Laurens-W does the failing test here and in main depend on

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/data/RefactorSimpleMongoDbFactory.java
    • lines 74-74

@timtebeek timtebeek merged commit 1c8d450 into main Nov 14, 2024
2 checks passed
@timtebeek timtebeek deleted the drop-old-runtime-spring-core-dependency branch November 14, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant