-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first approach of HttpClient5 migration #397
Conversation
I'm using this document as a support to map 4->5 classes and track deprecations and errors: |
I'd say a good start; maybe good to complement with just the basics of a unit test before we merge, but otherwise we're mostly testing existing recipes and how they work when combined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start & thanks for adding the test!
oldFullyQualifiedTypeName: org.apache.hc.client5.http.impl.classic.DefaultHttpClient | ||
newFullyQualifiedTypeName: org.apache.hc.client5.http.impl.classic.CloseableHttpClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the top one still available? Maybe best not to replace just yet in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because if we replace this early, then we might not be able to better target a replacement that introduces try-with-resources later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it's not available anymore... But I'm thinking on not just facing this "deprecated" issues yet, because in general is not as simple as just changing the type, since usually they don't have the same methods available...
What's changed?
Added a first approach of Apache Http Client 5 migration. Right now it adds the new dependency coordinates and performs all the obvious mappings between compatible classes changing the namespace.
Some attempts on some Deprecated classes have been done, but probably with some breaking changes right now. Will need more iteration.
What's your motivation?
Spring boot 3 migration requires HttpClient upgrade.
Issue: #300
Anyone you would like to review specifically?
@timtebeek