Skip to content

Commit

Permalink
Refactor test according to new specs
Browse files Browse the repository at this point in the history
  • Loading branch information
nielsdebruin committed Oct 29, 2024
1 parent 9adafb2 commit 6f9837d
Show file tree
Hide file tree
Showing 3 changed files with 175 additions and 361 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,16 @@
import org.openrewrite.java.JavaIsoVisitor;
import org.openrewrite.java.search.UsesType;

public class RequiredFieldIntoConstructorParameter extends Recipe {
public class ReplaceRequiredAnnotationOnSetterWithAutowired extends Recipe {

@Override
public String getDisplayName() {
return "Required field into constructor parameter";
return "Replace `@Required` annotation on setter with `@Autowired`";
}

@Override
public String getDescription() {
return "The RequiredFieldIntoConstructorParameter recipe moves fields which have setters marked with the " +
"@Required annotation to constructor parameters. It does not make changes when an existing constructor " +
"exists, for inherited fields, or for classes annotated with Lombok constructors.";
return "Replace setter methods annotated with `@Required` with `@Autowired`.";
}

@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
/*
* Copyright 2024 the original author or authors.
* <p>
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* <p>
* https://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.openrewrite.java.spring;

import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

import static org.openrewrite.java.Assertions.java;

class ReplaceRequiredAnnotationOnSetterWithAutowiredTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
spec.recipe(new ReplaceRequiredAnnotationOnSetterWithAutowired())
.parser(JavaParser.fromJavaVersion().classpath("spring-beans"));
}

@DocumentExample
@Test
void replaceRequiredWithAutowired() {
//language=java
rewriteRun(
java(
"""
import org.springframework.beans.factory.annotation.Required;
class Foo {
private String a;
@Required
void setA(String a) {
this.a = a;
}
}
""",
"""
import org.springframework.beans.factory.annotation.Autowired;
class Foo {
private String a;
@Autowired
void setA(String a) {
this.a = a;
}
}
"""
)
);
}

@Test
void replaceRequiredWithAutowiredMultipleSetters() {
rewriteRun(
//language=java
java(
"""
import org.springframework.beans.factory.annotation.Required;
class Foo {
private String a;
private String b;
@Required
void setA(String a) {
this.a = a;
}
@Required
void setB(String b) {
this.b = b;
}
}
""",
"""
import org.springframework.beans.factory.annotation.Autowired;
class Foo {
private String a;
private String b;
@Autowired
void setA(String a) {
this.a = a;
}
@Autowired
void setB(String b) {
this.b = b;
}
}
"""
)
);
}

@Test
void replaceRequiredWithAutowiredMultipleSettersNotAllRequired() {
rewriteRun(
//language=java
java(
"""
import org.springframework.beans.factory.annotation.Required;
class Foo {
private String a;
private String b;
void setA(String a) {
this.a = a;
}
@Required
void setB(String b) {
this.b = b;
}
}
""",
"""
import org.springframework.beans.factory.annotation.Autowired;
class Foo {
private String a;
private String b;
void setA(String a) {
this.a = a;
}
@Autowired
void setB(String b) {
this.b = b;
}
}
"""
)
);
}

@Test
void setterWithoutAnnotationsShouldNotCauseChanges() {
rewriteRun(
//language=java
java(
"""
class Foo {
private String a;
void setA(String a) {
this.a = a;
}
}
"""
)
);
}
}
Loading

0 comments on commit 6f9837d

Please sign in to comment.