-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python stub files #52
Support python stub files #52
Conversation
- https://mypy.readthedocs.io/en/stable/stubs.html - https://realpython.com/python-ellipsis/ Signed-off-by: Jonathan Leitschuh <[email protected]>
Currently seeing this error. It looks like arguments are getting re-ordered, which looks like it's likely a problem outside the scope of this change?
|
@garyolsen do you have any insights into why the arguments are getting re-ordered, which is causing the tests to fail? I have no insights here. |
@JLLeitschuh Yes, this is unrelated—the implementation of type hints in our model is being rendered incorrectly when there is a default value for a parameter. |
Should that get fixed first before this gets merged then? Do you have the cycles to fix that? |
I think it's fine to merge this first—I won't be able to look at the parsing/printing issue for at least a few days. Just omit the failing test for now and I'll add it back in when I fix the underlying issue. |
Hi @JLLeitschuh! I'm working on adding type attribution to the I'm still sorting out the details about configuring the workspace so that |
Sure, better to do it right than fast. What's the ETA? |
Thank you - I agree. I created a PythonCoreApplicationEnvironment, but I am still sorting out how to configure dependencies and IntelliJ's virtual file system to resolve types. PYI files are set into a specific workspace, but I need to figure out how that happens. I need a few days to sort out the requirements and will provide an ETA afterward. |
If you've got a plan here, I think I'll close this pull request |
Signed-off-by: Jonathan Leitschuh [email protected]