-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert any equals and hashcode to the lombok annotation, ignore implementation #647
Draft
timo-a
wants to merge
5
commits into
openrewrite:main
Choose a base branch
from
timo-a:lombok/convert-equals-negligently
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/org/openrewrite/java/migrate/lombok/NegligentlyConvertEquals.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/NegligentlyConvertEquals.java
Show resolved
Hide resolved
timo-a
force-pushed
the
lombok/convert-equals-negligently
branch
from
January 1, 2025 19:13
4ab6051
to
68838e4
Compare
src/main/java/org/openrewrite/java/migrate/lombok/NegligentlyConvertEquals.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/NegligentlyConvertEquals.java
Show resolved
Hide resolved
3 tasks
timo-a
force-pushed
the
lombok/convert-equals-negligently
branch
from
January 15, 2025 15:59
4d5d678
to
4194a9d
Compare
Now there is a seemingly unrelated error in /home/runner/work/rewrite-migrate-java/rewrite-migrate-java/src/main/java/org/openrewrite/java/migrate/javax/AddColumnAnnotation.java:92:
Maybe a rebase on |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timo-a
force-pushed
the
lombok/convert-equals-negligently
branch
from
January 15, 2025 16:48
7b8ffe4
to
51ffbc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
To convert classes to
@Value
or@Data
they need to have@EqualsAndHashCode
.But this annotation is probably not there.
equals()
andhashCode()
are if defined hard to validate, so this recipe assumes that manual work is necessary and adds@EqualsAndHashCode
to any class that implements eitherequals()
orhashCode()
regardless of how they are implemented. The user has to review each class, but saves the effort of finding and replacing.Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist