Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] NoGuavaJava21 causing invalid code since v2.28.0 #601

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

BramliAK
Copy link
Contributor

@BramliAK BramliAK commented Nov 13, 2024

What's changed?

Rollback visit Variable Declarations

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
    • lines 19-19

@timtebeek
Copy link
Contributor

hi @BramliAK ; Understand that you'd like this fixed; Instead of completely removing this, can we make this opt-in with an @Option instead? That way the nice addition you added in #590 isn't completely lost, and it opens the door to an alternative composite recipe that does potentially unsafe replacements.

timtebeek and others added 3 commits November 14, 2024 10:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines +18 to 19
import java.time.Duration;
import org.jspecify.annotations.Nullable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import java.time.Duration;
import org.jspecify.annotations.Nullable;
import org.jspecify.annotations.Nullable;

Comment on lines 34 to 35
import java.util.ArrayList;
import java.util.List;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import java.util.ArrayList;
import java.util.List;
import java.time.Duration;
import java.util.List;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants