-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HotFix] NoGuavaJava21 causing invalid code since v2.28.0 #601
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
- lines 19-19
hi @BramliAK ; Understand that you'd like this fixed; Instead of completely removing this, can we make this opt-in with an |
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
import java.time.Duration; | ||
import org.jspecify.annotations.Nullable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import java.time.Duration; | |
import org.jspecify.annotations.Nullable; | |
import org.jspecify.annotations.Nullable; |
import java.util.ArrayList; | ||
import java.util.List; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import java.util.ArrayList; | |
import java.util.List; | |
import java.time.Duration; | |
import java.util.List; |
What's changed?
Rollback visit Variable Declarations
Checklist