Recipes to replace Guava Immutable{Set|List|Map}.copyOf() with Java {Set|List|Map}.copyOf()
#587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `{Set|List|Map}.copyOf()`
Fixes #584
Add recipes to replace Guava `ImmutableSet.copyOf()`, `ImmutableList.copyOf()`, and `ImmutableMap.copyOf()` calls with Java `Set.copyOf()`, `List.copyOf()`, and `Map.copyOf()` calls.
* Add `AbstractNoGuavaImmutableCopyOf` class to provide a base for the new recipes.
* Add `NoGuavaImmutableSetCopyOf`, `NoGuavaImmutableListCopyOf`, and `NoGuavaImmutableMapCopyOf` classes extending `AbstractNoGuavaImmutableCopyOf`.
* Update `no-guava.yml` to include the new recipes.
* Add test classes `NoGuavaImmutableSetCopyOfTest`, `NoGuavaImmutableListCopyOfTest`, and `NoGuavaImmutableMapCopyOfTest` with test cases for the new recipes.
---
For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/openrewrite/rewrite-migrate-java/issues/584?shareId=XXXX-XXXX-XXXX-XXXX).
|
In my opinion, a new abstract class known as AbstractNoGuavaImmutable can be created and the common methods can be added to it. We can further expand it with AbstractNoGuavaImmutableCopyOf.java and AbstractNoGuavaImmutableOf.java to eliminate the use of duplicated code. |
|
I was thinking along the same lines, especially after the improvements you added @BramliAK ; reuse between these two is likely preferred over duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immutable{Set|List|Map}.copyOf()calls with Java{Set|List|Map}.copyOf()calls #584Add recipes to replace Guava
ImmutableSet.copyOf(),ImmutableList.copyOf(), andImmutableMap.copyOf()calls with JavaSet.copyOf(),List.copyOf(), andMap.copyOf()calls.AbstractNoGuavaImmutableCopyOfclass to provide a base for the new recipes.NoGuavaImmutableSetCopyOf,NoGuavaImmutableListCopyOf, andNoGuavaImmutableMapCopyOfclasses extendingAbstractNoGuavaImmutableCopyOf.no-guava.ymlto include the new recipes.NoGuavaImmutableSetCopyOfTest,NoGuavaImmutableListCopyOfTest, andNoGuavaImmutableMapCopyOfTestwith test cases for the new recipes.For more details, open the Copilot Workspace session.