Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor rewrite.resolvePropertiesInYaml flag in classpath scanning #887

Merged

Conversation

jpraet
Copy link
Contributor

@jpraet jpraet commented Oct 30, 2024

The rewrite.resolvePropertiesInYaml flag introduced in #741 was only applied to the yaml file from the configLocation.

This PR also applies the flag to recipes loaded from the classpath.

The rewrite.resolvePropertiesInYaml flag introduced in openrewrite#741
was only applied to the yaml file from the configLocation.

This PR also applies the flag to recipes loaded from the classpath.
@timtebeek timtebeek self-requested a review October 30, 2024 22:01
@timtebeek timtebeek changed the title Honor rewrite.resolvePropertiesInYaml flag in classpath scanning Honor rewrite.resolvePropertiesInYaml flag in classpath scanning Oct 30, 2024
@timtebeek timtebeek added the enhancement New feature or request label Oct 30, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the immediate fix!

@timtebeek timtebeek merged commit 8f7d930 into openrewrite:main Oct 30, 2024
1 check passed
@timtebeek
Copy link
Contributor

Available now in https://github.com/openrewrite/rewrite-maven-plugin/releases/tag/v5.43.4
Do let us know how that works out for you! :)

@jpraet
Copy link
Contributor Author

jpraet commented Nov 5, 2024

Thanks, working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants