Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary goal + grammar fixes for other goals #609

Merged
merged 3 commits into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public void execute() throws MojoExecutionException {
return;
}

//If the plugin is configured to run over all projects (at the end of the build) only proceed if the plugin
//is being run on the last project.
// If the plugin is configured to run over all projects (at the end of the build) only proceed if the plugin
// is being run on the last project.
if (!runPerSubmodule && !project.getId().equals(mavenSession.getProjects().get(mavenSession.getProjects().size() - 1).getId())) {
return;
}
Expand All @@ -70,22 +70,22 @@ public void execute() throws MojoExecutionException {
if (results.isNotEmpty()) {
for (Result result : results.generated) {
assert result.getAfter() != null;
getLog().warn("These recipes would generate new file " +
getLog().warn("These recipes would generate a new file " +
result.getAfter().getSourcePath() +
":");
logRecipesThatMadeChanges(result);
}
for (Result result : results.deleted) {
assert result.getBefore() != null;
getLog().warn("These recipes would delete file " +
getLog().warn("These recipes would delete a file " +
result.getBefore().getSourcePath() +
":");
logRecipesThatMadeChanges(result);
}
for (Result result : results.moved) {
assert result.getBefore() != null;
assert result.getAfter() != null;
getLog().warn("These recipes would move file from " +
getLog().warn("These recipes would move a file from " +
result.getBefore().getSourcePath() + " to " +
result.getAfter().getSourcePath() + ":");
logRecipesThatMadeChanges(result);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public void execute() throws MojoExecutionException {
return;
}

//If the plugin is configured to run over all projects (at the end of the build) only proceed if the plugin
//is being run on the last project.
// If the plugin is configured to run over all projects (at the end of the build) only proceed if the plugin
// is being run on the last project.
if (!runPerSubmodule && !project.getId().equals(mavenSession.getProjects().get(mavenSession.getProjects().size() - 1).getId())) {
return;
}
Expand Down
80 changes: 0 additions & 80 deletions src/main/java/org/openrewrite/maven/RemoveMojo.java

This file was deleted.

5 changes: 3 additions & 2 deletions src/main/java/org/openrewrite/maven/RewriteDiscoverMojo.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@
import java.util.HashSet;

/**
* Generate a report of available recipes found on the classpath.<br>
* {@code ./mvnw rewrite:discover -Ddetail=true -Drecipe=<recipe-name>} to display recipe configuration details. For example:<br>
* Generate a report of the available recipes and styles found on the classpath.<br>
* <br>
* Can also be used to display information about a specific recipe. For example:<br>
* {@code ./mvnw rewrite:discover -Ddetail=true -Drecipe=org.openrewrite.java.format.AutoFormat}
*/
@Mojo(name = "discover", threadSafe = true, requiresProject = false, aggregator = true)
Expand Down
42 changes: 0 additions & 42 deletions src/main/java/org/openrewrite/maven/RewriteDumpMavenSettings.java

This file was deleted.

39 changes: 0 additions & 39 deletions src/test/java/org/openrewrite/maven/RemoveMojoIT.java

This file was deleted.