Adding two abstract visitor classes for XXE vulnerabilities #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaronist
commented
Aug 17, 2023
•
aaronist
commented
- Add two abstract visitors (one to search, one to update) for XXE vulnerabilities to allow for easier addition of new XML parsers
- Additional code cleanup
JLLeitschuh
requested changes
Aug 17, 2023
| @Getter | ||
| public abstract class XmlFactoryInsertVisitor<P> extends JavaIsoVisitor<P> { | ||
| private final J.Block scope; | ||
| private final StringBuilder template; |
There was a problem hiding this comment.
Just assign this to a new string builder, then you don't need to pass it in the super call
| return s != null ? s.getCoordinates().before() : b.getCoordinates().lastStatement(); | ||
| } | ||
|
|
||
| public J.Block updateTemplate(J.Block b, J.Block block, Statement beforeStatement, Set<String> imports) { |
There was a problem hiding this comment.
Curious about this method name
| maybeAddImport("javax.xml.XMLConstants"); | ||
| Statement beforeStatement = getInsertStatement(b); | ||
| if (b.isScope(getScope())) { | ||
| b = updateTemplate(b, block, beforeStatement, Stream.of("javax.xml.XMLConstants").collect(Collectors.toSet())); |
There was a problem hiding this comment.
Suggested change
| b = updateTemplate(b, block, beforeStatement, Stream.of("javax.xml.XMLConstants").collect(Collectors.toSet())); | |
| b = updateTemplate(b, block, beforeStatement, Collections.single("javax.xml.XMLConstants")); |
Not sure I got the method name entirely correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.