Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Random import during SecureRandom recipe #132

Merged
merged 1 commit into from
May 7, 2024
Merged

Remove Random import during SecureRandom recipe #132

merged 1 commit into from
May 7, 2024

Conversation

Bananeweizen
Copy link
Contributor

What's changed?

Removes java.util.Random import during SecureRandom recipe.

What's your motivation?

Fixes #131

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

timtebeek
timtebeek approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again!

@timtebeek timtebeek merged commit b7aed0e into openrewrite:main May 7, 2024
2 checks passed
@Bananeweizen Bananeweizen deleted the random_import branch May 7, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SecureRandom should have maybeRemoveImport("java.util.Random")
2 participants
@Bananeweizen @timtebeek