Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonexistent recipe from yaml #128

Closed

Conversation

Bananeweizen
Copy link
Contributor

What's changed?

Removes nonexistent recipe from yaml recipe list.

What's your motivation?

Fixes #127.

Anyone you would like to review specifically?

@jkschneider created commit 894f757 and might know best.

Have you considered any alternatives or workarounds?

Instead of removing the line, we could have changed it to the new recipe that was introduced within the same commit. But for me that recipe doesn't fit the Owasp category description.

It would be good to have a more general fix that actually verifies that all yaml recipes contain only valid references to existing recipes in the same jar. I think there was a previous issue where the Owasp list also contained a broken reference.

@knutwannheden
Copy link
Contributor

Agreed. It would be good if the build would verify all META-INF/rewrite/*.yml files in the jar file of recipe libraries.

@Bananeweizen
Copy link
Contributor Author

Was fixed independently in 8eec567

@Bananeweizen Bananeweizen deleted the owasp_nonexistent branch March 18, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Owasp recipe refers to missing Spring recipe
2 participants