Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/SN/continueDBFPatch #105

Merged
merged 6 commits into from
Aug 28, 2023

Conversation

Saumyanavani
Copy link
Contributor

  • Fixed issues with generation of extra braces/new lines.
  • Refactor DBF onto XmlFactoryVisitor
  • Removed duplicate test case, fixed issues with code generation
  • cleaned up code + comments

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files
  • I've updated the documentation (if applicable)

@@ -259,7 +209,7 @@ class myDBFReader {
}

@Test
@Disabled("Temporarily")
// @Disabled("Temporarily")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

@JLLeitschuh JLLeitschuh merged commit c3cdec3 into openrewrite:main Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants