feature: Re-implement ngx_lua's ngx.decode_args API function with FFI #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our projects had used a lot of
ngx.decode_args
API function.When i make a performance test for this project on the Flame Graph. I found the
ngx.decode_args
API function occupied most of CPU utilization, which reduce QPS seriously. So i re-implement thengx.decode_args
API function with FFI.I use this code to test:
The result is:
for lua c api
2.7109999656677
for ffi
1.3810000419617
It seems 100% faster, that's great!
@agentzh
What do you think about this PR?
And also openresty/lua-nginx-module#1108.
Thanks!