Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: 8bit/16bit, big-endian/little-endian in nexrad reader #231

Merged
merged 5 commits into from
Nov 2, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Nov 2, 2024

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.78%. Comparing base (794c606) to head (7cd1eb6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xradar/io/backends/nexrad_level2.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   92.80%   92.78%   -0.02%     
==========================================
  Files          26       26              
  Lines        5003     5005       +2     
==========================================
+ Hits         4643     4644       +1     
- Misses        360      361       +1     
Flag Coverage Δ
notebooktests 79.02% <90.00%> (-0.02%) ⬇️
unittests 91.18% <30.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

kmuehlbauer commented Nov 2, 2024

@syedhamidali Could you please test your workflow with these changes?

We would have to create a release branch for the 0.7-line and backport this. Otherwise users are forced to upgrade to latest xarray. This might take some time to figure out the workflows, though.

@syedhamidali
Copy link
Contributor

@kmuehlbauer Yes looks better now. Thank you!
image

@kmuehlbauer kmuehlbauer changed the title fix 8bit/16bit, big-endian/little-endian in nexrad reader FIX: 8bit/16bit, big-endian/little-endian in nexrad reader Nov 2, 2024
@kmuehlbauer kmuehlbauer merged commit 1dce43b into openradar:main Nov 2, 2024
10 of 12 checks passed
@kmuehlbauer kmuehlbauer deleted the nexrad-zdr branch November 2, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Issue with ZDR when reading data with nexrad_level2 reader
2 participants