refactor(cloudflare): rename the "cloudflare" wrapper to "cloudflare-edge"

[vicb]

The commit message do not mention "cloudflare-streaming" -> "cloudflare-node" as this was never released officially.

[changeset-bot]

🦋 Changeset detected

Latest commit: da97b15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@opennextjs/aws	Patch
app-pages-router	Patch
app-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@645

commit: e7ed235

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	21.98%	1659 / 7545
🔵	Statements	21.98%	1659 / 7545
🔵	Functions	56.25%	99 / 176
🔵	Branches	70.28%	414 / 589

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/open-next/src/build/createMiddleware.ts	0%	0%	0%	0%	1-86
packages/open-next/src/build/helper.ts	0%	0%	0%	0%	1-376
packages/open-next/src/build/validateConfig.ts	0%	0%	0%	0%	1-116
packages/open-next/src/build/edge/createEdgeBundle.ts	0%	0%	0%	0%	1-241
packages/open-next/src/helpers/withCloudflare.ts	0%	100%	100%	0%	79-118
packages/open-next/src/plugins/resolve.ts	0%	0%	0%	0%	1-111
packages/open-next/src/types/open-next.ts	0%	0%	0%	0%

Generated in workflow #781 for commit e7ed235 by the Vitest Coverage Report Action

[conico974]

I think we should change the Wrapper type so that it is clearer (and would allow for better validation). It could become

export type Wrapper<
  E extends BaseEventOrResult = InternalEvent,
  R extends BaseEventOrResult = InternalResult,
> = BaseOverride & {
  wrapper: WrapperHandler<E, R>;
  supportStreaming: boolean;
  supportExternalMiddleware?: boolean
  edgeLikeRuntime?: boolean;
};

edgeLikeRuntime would be used at build time to apply the necessary fix for cloudflare. It would also help distinguish this from Next edge runtime. This would be set for both cloudflare wrappers.
I don't like this name a lot, maybe you can find something better. Maybe something with Worker or WinterCG

supportExternalMiddleware would only be used for validation because external middleware need to be able to handle both InternalResult and MiddlewareOutputEvent. This one would be set to true for the aws-cloudfront wrapper as well.

All of this could be done in a different PR if you prefer.

[vicb]

All of this could be done in a different PR if you prefer.

Yes, I would prefer a different PR as I think we probably need to refactor the code.
See #646

[conico974]

LGTM Thanks

[vicb]

Thanks for the review!