Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-started.mdx #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

codercatdev
Copy link

in the bottom how to deploy section it has deploy:worker I think this should match.

in the bottom how to deploy section it has `deploy:worker` I think this should match.
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-piotrowicz what do you think?
C3 template uses deploy.
We should pick either one, maybe :worker everywhere and we update here, c3, and the adapter repo?

@dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz what do you think? C3 template uses deploy. We should pick either one, maybe :worker everywhere and we update here, c3, and the adapter repo?

@vicb if you look at the c3.ts files for all the various types of projects you will see that all of them use "deploy" (without ":worker" or any other suffix/prefix) and I am a big fan of consistency, so if I had to chose I would go for that, I'm not against deploy:worker anyways if that's your preference


PS: Thanks for spotting the issue @codercatdev 🫶

@vicb
Copy link
Contributor

vicb commented Feb 4, 2025

What I mean is consistency can be 2 two things:

  1. everything worker related ends with i.e. use preview:worker and deploy:worker to match build:worker and dev:worker
  2. or use deploy and preview to be consistent with the c3 template

I updated (some of) the docs in #50 to use deploy and preview to match the template.

But now I'm wondering if we shouldn't got the 1 way (in docs + templates)

@dario-piotrowicz
Copy link
Contributor

What I mean is consistency can be 2 two things:

  1. everything worker related ends with i.e. use preview:worker and deploy:worker to match build:worker and dev:worker
  2. or use deploy and preview to be consistent with the c3 template

I updated (some of) the docs in #50 to use deploy and preview to match the template.

But now I'm wondering if we shouldn't got the 1 way (in docs + templates)

my preference as I mentioned is to be consistent with the c3 template (2.) and remove the :worker to all the scripts that don't need it (note: the only one from which we can't remove the suffix is build:worker as we can't simply use build)

but again, I'm ok to go with 1. if that's your preference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants